[SDBELGA-759] Feature: Sync Event metadata to Planning & Coverages #1892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@petrjasek The code is ready to be reviewed. I have placed this PR in draft state while I add tests |
Embedded/Sync wasn't working once above bug was fixed
petrjasek
approved these changes
Jan 3, 2024
I don't mind the use of dataclasses, as it provides:
On the other hand, dataclasses should never be used with data that will be used in a:
This is because the data would have to be serialised, which means converting it to a dict first, in which case a dict should be used. Thoughts @petrjasek? |
|
makes sense |
MarkLark86
added a commit
to MarkLark86/superdesk-planning
that referenced
this pull request
Jan 30, 2024
…uperdesk#1892) * Config: Add new config for Event to Planning sync * ui: Send `embedded_planning` from front-end * api: Improve Planning ContentProfiles module and types * api: Process `embedded_planning` and sync metadata * fix(ui): Failed to get lock for recurring series * fix(ui): Improve EmbeddedCoverageForm UI * fix(ui): Event to Planning translations copies fields multiple times * fix(e2e): Use chrome in CI to run tests * Add behave tests for embedded planning * Add behave tests for multilingual embedded planning * Add CVs to behave test * fix: Coverage Planning updated when processing Assignment details Embedded/Sync wasn't working once above bug was fixed * Add behave tests for event metadata sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also moves the EmbeddedPlanning from a front-end feature to be a back-end feature (so that metadata sync and associated planning can be handled with the 1 request, and the 1 DB change).